feat: Use Trusted Publishers with GitLab CI/CD #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matthewfeickert
commented
Apr 17, 2024
matthewfeickert
commented
- PyPI Trusted Publisher support now includes GitLab CI/CD, so use generated OIDC tokens to publish to TestPyPI or PyPI as needed in GitLab pipelines.
- c.f. https://blog.pypi.org/posts/2024-04-17-expanding-trusted-publisher-support/
matthewfeickert
commented
Apr 17, 2024
Comment on lines
155
to
160
| # Retrieve the OIDC token from GitLab CI/CD and exchange it for a PyPI API token | ||
| - oidc_token=$(python -m id PYPI) | ||
| - response=$(curl -X POST "${OIDC_MINT_TOKEN_URL}" -d "{\"token\":\"${oidc_token}\"}") | ||
| - api_token=$(jq --raw-output '.token' <<< "${response}") | ||
|
|
||
| - pipx run twine upload --password "${api_token}" --verbose dist/*whl dist/*gz |
There was a problem hiding this comment.
These steps are currently based off of those show in pypi/warehouse#13575 (comment). @kratsg can you please try this PR's changes on one of your CERN GitLab projects to validate them before we request review?
There was a problem hiding this comment.
Ah they're actually in the docs now: https://docs.pypi.org/trusted-publishers/using-a-publisher/#gitlab-cicd and https://docs.pypi.org/trusted-publishers/security-model/#gitlab-cicd
matthewfeickert
force-pushed
the
feat/use-trusted-publisher-for-gitlab
branch
from
ccc0e99
to
553190e
Compare
matthewfeickert
force-pushed
the
feat/use-trusted-publisher-for-gitlab
branch
from
553190e
to
8a55804
Compare
* PyPI Trusted Publisher support now includes GitLab CI/CD, so use generated OIDC tokens to publish to TestPyPI or PyPI as needed in GitLab pipelines. - c.f. https://blog.pypi.org/posts/2024-04-17-expanding-trusted-publisher-support/
* Requires id v1.4.0+
matthewfeickert
force-pushed
the
feat/use-trusted-publisher-for-gitlab
branch
from
8a55804
to
14518cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.