Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Removed pinning of wheel #10

Merged
merged 5 commits into from
May 9, 2019
Merged

Removed pinning of wheel #10

merged 5 commits into from
May 9, 2019

Conversation

radarhere
Copy link

@radarhere radarhere changed the title V0.14.x Removed pinning of wheel Dec 7, 2018
@hmaarrfk
Copy link
Member

hmaarrfk commented May 6, 2019

The issue is that now dask requires numpy 1.13... so if we want to test with older number, we need to find the appropriate dask version.

@hmaarrfk
Copy link
Member

hmaarrfk commented May 6, 2019

Need to stick to 1.1.5
https://github.com/dask/dask/blob/1.1.5/setup.py

@radarhere
Copy link
Author

Hi. Sorry, I'm not following. What does this issue about auditwheel and multibuild have to do with numpy?

@hmaarrfk
Copy link
Member

hmaarrfk commented May 6, 2019

It itself has nothing with to do with numpy, but your builds aren't passing because we are forcing numpy 1.11 to be installed, but newly released dask requires a newer version....

@hmaarrfk
Copy link
Member

hmaarrfk commented May 6, 2019

Seems to be working now :/ I think it is because after you submitted the original PR, we removed dask from the list of core requirements from the library.

https://github.com/scikit-image/scikit-image/blob/v0.14.x/requirements/default.txt

@hmaarrfk hmaarrfk added the 0.14.3 label May 6, 2019
@stefanv stefanv merged commit c4a8e95 into scikit-image:v0.14.x May 9, 2019
@radarhere radarhere deleted the v0.14.x branch May 9, 2019 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants