-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random_walker regression #4771
Fix random_walker regression #4771
Conversation
This reverts commit db38358.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! thanks @rfezzani
Might be worth backporting it.
@scikit-image/core We need a second review on this bugfix (easy to read). |
If the test failures are unrelated, go ahead and merge. |
They are. i'm merging. Thanks @stefanv |
@meeseeksdev backport to v0.17.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
🎉 Thank you @sciunto ;) |
Description
Fix #4770.
Regression was introduced in 8f76f0f.
This PR
random_walker
segmentation when labels contains isolated areatest_isolated_area
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.