Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs to the install page #6998

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

matthiasnwt
Copy link
Contributor

Description

Just a small fix of four URLs which should lead to the install page but resulted in a 404 error.

"https://scikit-image.org/docs/stable/install.html"

changed to

"https://scikit-image.org/docs/stable/user_guide/install.html"

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@matthiasnwt matthiasnwt changed the title Correct URLs to the install page Fix URLs to the install page Jun 5, 2023
@matthiasnwt
Copy link
Contributor Author

As I haven't change any code, failing the tests is probably related to #6994

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Jun 5, 2023
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @matthiasnwt! Yes, CI failures should be unrelated to this PR.
There's this one #7000, which we keep seeing today, but the other one about batch sizes... I'm not sure.

@stefanv stefanv merged commit 6a734bb into scikit-image:main Jun 5, 2023
@stefanv stefanv added this to the 0.22 milestone Jun 5, 2023
@matthiasnwt matthiasnwt deleted the correct-install-url branch June 7, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants