Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin imageio and add warningfilter #7006

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

lagru
Copy link
Member

@lagru lagru commented Jun 6, 2023

Description

Closes #7000. Reverts #7002.

A bit unsure how to specifiy the requirement after which the filter can be removed but this should be good enough...?

cc @FirefoxMetzger, @jarrodmillman

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

A bit unsure how to specifiy the requirement after which the filter can
be removed but this should be good enough...?
@lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jun 6, 2023
@jarrodmillman
Copy link
Contributor

Should this also close #6994 or do we need to make a new release?

@jarrodmillman jarrodmillman merged commit 359d4e3 into scikit-image:main Jun 7, 2023
@stefanv stefanv added this to the 0.22 milestone Jun 7, 2023
@lagru lagru deleted the unpin-imageio branch June 8, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure with imageio==2.31.0
3 participants