BF - metadata version when using editable install

[gabknight]

importlib.metadata.version doesn't work for package not installed with pip, i.e. when using a local editable version (python/importlib_metadata#364)

The problem is solved by calling scilpy.version instead of metadata.version.

@arnaudbore @AlexVCaron do you see a problem with this change?

[AlexVCaron]

That's perfect with me. I did not think of fetching the version directly from that file !

[arnaudbore]

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-812/1/

[arnaudbore]

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-812/2/

[AlexVCaron]

There is a missing file in MANIFEST.in, the .python-version file, which is required to import version.py. Adding it should fix the crashing tests

[gabknight]

ok thx @AlexVCaron!

@arnaudbore I noticed in scilpy.version.py _version_micro is not added to __version__ if 0. For instance, the current __version__ is "1.6". If version_extra != '' and _verison_micro==0, scilpy version will be wrong: major.minor.extra.

I suggest changing the line if _version_micro: to if len(_version_micro):, producing "1.6.0" or "1.6" if _version_micro is set to ''. What do you think?

_version_major = 1
_version_minor = 6
_version_micro = 0
_version_extra = ''

# Construct full version string from these.
_ver = [_version_major, _version_minor]
if _version_micro:
    _ver.append(_version_micro)
if _version_extra:
    _ver.append(_version_extra)

__version__ = '.'.join(map(str, _ver))

[arnaudbore]

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-812/3/

[arnaudbore]

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-812/4/

[gabknight]

ok... I didn't know how to have access to .python-version both through setup.py and scilpy.version, in both editable and egg installs.

I removed the PYTHON_VERSION variable from scilpy.version. It was only used in setup.py. setup.py now reads it directly from .python-version.

[arnaudbore]

Build passed ! Good Job 🍻 !

[arnaudbore]

GTG