Support most callables #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
src/sciline/_provider.py
Outdated
Comment on lines
290
to
294
| if isinstance(func, type): | ||
| raise TypeError( | ||
| "Classes are not supported as providers because their type annotations " | ||
| f"cannot reliably be extracted. Got class {func}. " | ||
| "Consider using a free function, classmethod, or staticmethod." |
There was a problem hiding this comment.
Is it worth mentioning that this is about classes, not class instances? While clear to us, an average user may forget to instantiate a class and not know the difference?
Comment on lines
+317
to
+321
| # Drop `self` / `cls` | ||
| args = args[1:] |
There was a problem hiding this comment.
What if this is a staticmethod? Does this actually take the inspect.isfunction branch?
There was a problem hiding this comment.
Yes. See
sciline/tests/pipeline_test.py
Line 1507 in 1a75b95
No, it's here: sciline/tests/pipeline_test.py Line 1495 in 1a75b95 |
jl-wynen
force-pushed
the
support-all-callables
branch
from
1a75b95 to
b36dfa9
Compare
SimonHeybrock
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114