Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query_orbit_by_dt fails for scenes for which no precision orbit is available #39

Closed
asjohnston-asf opened this issue Aug 18, 2023 · 1 comment
Closed

query_orbit_by_dt fails for scenes for which no precision orbit is available #39

asjohnston-asf opened this issue Aug 18, 2023 · 1 comment

Comments

@asjohnston-asf
Copy link

See dbekaert/RAiDER#576

_select_orbit defined at https://github.com/scottstanie/sentineleof/blob/master/eof/scihubclient.py#L88 has no orbit_type parameter, but it's called with that parameter at https://github.com/scottstanie/sentineleof/blob/master/eof/scihubclient.py#L168 . This results in a TypeError: ScihubGnssClient._select_orbit() got an unexpected keyword argument 'orbit_type' exception for scenes for which no precision orbit is available.
scottstanie added a commit that referenced this issue Aug 18, 2023
@scottstanie
add failing test for #39
ceba5f3
@scottstanie scottstanie mentioned this issue Aug 18, 2023
Merged
@scottstanie
Copy link
Owner

Very sorry about that. I've pushed a fix #40

It'll be up on pypi shortly, and i'll bump the conda-forge version once that's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottstanie @asjohnston-asf