-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add for decoding x-www-form-urlencoded data #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mitchellwrosen I've fixed the conflicts, now waiting for CI and we're good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http-api-data import is missing.
@@ -65,6 +66,7 @@ import Network.Wai | |||
|
|||
import Numeric.Natural | |||
|
|||
import qualified Web.FormUrlEncoded as F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed that CI fails because this module is not in scope. @mitchellwrosen could you add the 'http-api-data' import in the cabal file?
@ocramz Sorry but I'm not sure I have the context or bandwidth to dedicate to this 5 year old PR of mine. I'm not a scotty user :( I will note that the commit I made looks rather different than the PR in its current form. Here is my commit: 2a7db35 I think the merge commit you made into this branch 2 weeks ago has accidentally added some unwanted stuff, somehow: 4ea5e7f |
@mitchellwrosen apologies, I must have made a mistake while fixing conflicts. Closing this for now and resuming at #321 |
Here ya go if you'd like it - decoding
x-www-form-urlencoded
request bodies a lajsonData