(#194) Fix numbers decimal separator #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiflai
reviewed
May 21, 2023
| } | ||
| } catch (FileNotFoundException fnfe) { | ||
| throw new GradleException(fileNotFoundErrorMsg(coverageType), fnfe) | ||
| } | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| protected static String errorMsg(String actual, String expected, CoverageType type) { | ||
| protected static String errorMsg(double overallRate, double minimumRate, CoverageType type) { | ||
| DecimalFormat df = new DecimalFormat("#.##", DecimalFormatSymbols.getInstance(Locale.ENGLISH)) |
There was a problem hiding this comment.
Sorry - perhaps https://github.com/maiflai/scalac-scoverage-plugin/blob/67166cd89737bf7a2fc14d8b7a4dafca4f39046d/domain/src/main/scala/scoverage/domain/DoubleFormat.scala#L18 suggests we should be using Locale.US?
I tried not to bring scoverage classes into the classpath to avoid clashes with other plugins.
There was a problem hiding this comment.
I do not mind, changed to Locale.US as it also uses "." as a separator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #194