Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing old git tags in the repository #110

Closed
Skunnyk opened this issue Feb 10, 2023 · 4 comments
Closed

Remove confusing old git tags in the repository #110

Skunnyk opened this issue Feb 10, 2023 · 4 comments

Comments

@Skunnyk
Copy link

Skunnyk commented Feb 10, 2023

Hi,

In the git repository (https://github.com/scylladb/gocql/tags), there are old git tags with higher digit number than current release !
Some dependency tools (like renovate bot) are confused and get release 1.10.0 for example.
Last scylladb/gocql official release is 1.7.3, but we have tags numbered 1.8.0 or 1.10.0 from 2021! This is confusing.

Is it possible to remove theses old tags or do something ? :)

Thank you !

@martin-sucha
Copy link

Beware that removing tags will not remove the tags from git clones nor cached packages from module proxies. It might be safer to just release a new version that has higher version than all previous tags. And mark the unwanted versions as retracted in the Go module.

@Skunnyk
Copy link
Author

Skunnyk commented Feb 10, 2023

Yes, deleting old tags can be a problem. So next version slot is 1.11.0 then… :)

@carlosms
Copy link

Until this is fixed, please consider updating the instructions in the readme:

gocql/README.md

Lines 23 to 35 in e38b2bc

Add the following line to your project `go.mod` file.
```
replace github.com/gocql/gocql => github.com/scylladb/gocql latest
```
and run
```
go mod tidy
```
to evaluate `latest` to a concrete tag.

This will put v1.10.0 in the go.mod file.

In my opinion it might be simpler for everyone to release a higher version number right now, even if it's the exact same commit as 1.7.3.

@avelanarius
Copy link

I decided on the approach of removing old tags and all unrelated tags are now deleted from this repo.

avelanarius added a commit to avelanarius/gocql that referenced this issue Jul 20, 2023
Retract v1.8.0, v1.8.1, v1.9.0, v1.10.0 - tags mistakenly taken from
kiwicom/gocql, which are not actual releases made in scylladb/gocql.

Even though those tags were removed from scylladb/gocql (see scylladb#110),
some Go module mirrors have already fetched them:

  $ go list -m --versions github.com/scylladb/gocql
  github.com/scylladb/gocql v1.0.0 v1.0.1 v1.0.2 v1.0.3 v1.0.4 v1.1.0 v1.2.0 v1.2.1 v1.3.0-rc.1 v1.3.0 v1.3.1 v1.3.2 v1.3.3 v1.3.4 v1.4.0 v1.4.1 v1.4.2 v1.4.3 v1.5.0 v1.6.0 v1.7.0 v1.7.1 v1.7.2 v1.7.3 v1.8.0 v1.8.1 v1.9.0 v1.10.0

As we can't control those mirrors, they will always return an incorrect
version of gocql, even if we release "new" 1.9.0, 1.10.0.

Subsequent to merging of this patch, version v1.11.0 of scylladb/gocql
will be released.
avelanarius added a commit to avelanarius/gocql that referenced this issue Jul 20, 2023
Retract v1.8.0, v1.8.1, v1.9.0, v1.10.0 - tags mistakenly taken from
kiwicom/gocql, which are not actual releases made in scylladb/gocql.

Even though those tags were removed from scylladb/gocql (see scylladb#110),
some Go module mirrors have already fetched them:

  $ go list -m --versions github.com/scylladb/gocql
  github.com/scylladb/gocql v1.0.0 v1.0.1 v1.0.2 v1.0.3 v1.0.4 v1.1.0 v1.2.0 v1.2.1 v1.3.0-rc.1 v1.3.0 v1.3.1 v1.3.2 v1.3.3 v1.3.4 v1.4.0 v1.4.1 v1.4.2 v1.4.3 v1.5.0 v1.6.0 v1.7.0 v1.7.1 v1.7.2 v1.7.3 v1.8.0 v1.8.1 v1.9.0 v1.10.0

As we can't control those mirrors, they will always return an incorrect
version of gocql, even if we release "new" 1.9.0, 1.10.0.

Subsequent to merging of this patch, version v1.11.0 of scylladb/gocql
will be released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants