Add healthchecks, switch from Docker Compose V1 to V2 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Docker: "From July 2023 Docker Compose V1 stopped receiving updates. It’s also no longer available in new releases of Docker Desktop." This patch replaces all uses of "docker-compose" command (Docker Compose V1) with "docker compose" command (Docker Compose V2). This change will also allow for using new functionality introduced in Docker Compose V2, such as "--wait" flag.
mmatczuk
reviewed
Jul 17, 2023
| @@ -21,6 +21,11 @@ services: | |||
| - type: bind | |||
| source: ./testdata/pki/cassandra.key | |||
| target: /etc/scylla/db.key | |||
| healthcheck: | |||
There was a problem hiding this comment.
This means it would take 5 minutes for Docker to claim Scylla unhealthy.
There was a problem hiding this comment.
I followed the healthchecks in the Rust driver (https://github.com/scylladb/scylla-rust-driver/blob/main/test/cluster/docker-compose.yml#L25), do you suggest other values in the healthcheck?
avelanarius
previously approved these changes
Jul 17, 2023
Manually checking the health of a container with use of "cqlsh" replaced with healthcheck in docker-compose.yml file. Healthcheck uses "cqlsh" as well so it checks if all nodes of the cluster are fully bootstrapped and their CQL port ready. When using "--wait" flag (introduced in Docker Compose V2)in "docker compose up", Docker waits for all healthchecks to be in "healthy" state.
sylwiaszunejko
force-pushed
the
healthchecks
branch
from
059e8b3 to
282d587
Compare
Done |
avelanarius
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Docker documentation:
Therefore, the first patch replaces all uses of Docker Compose V1 (
docker-composecommand) with Docker Compose V2 (docker composecommand) and changes installed version of Docker Compose in main.yml.This gives a possibility to replace manual checking the health of the containers with healthchecks and using
--waitflag indocker compose.--wait flagmakes Docker wait for all healthchecks to be in "healthy" state. Since docker-compose.yml files in this repository usecqlshto determine the health of a container, this means that Docker will wait for all nodes of the cluster to be fully bootstrapped and their CQL port ready.All of this makes adding new nodes and making them boot in order easier, it is just adding new healthchecks and dependencies.