Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cluster.Keyspace before connecting to the nodes #97

Merged
merged 1 commit into from
Sep 4, 2022
Merged

use cluster.Keyspace before connecting to the nodes #97

merged 1 commit into from
Sep 4, 2022

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Jun 30, 2022 •
edited
Loading

Seem what's described in apache/cassandra-gocql-driver#1621 might be
affecting us, and making scylla-bench send unblanced
traffic to scylla

REF: apache/cassandra-gocql-driver#1621

@fruch fruch changed the title Work around gocql 1621 use cluster.Keyspace before connecting to the nodes Jun 30, 2022
@fruch fruch requested a review from vponomaryov June 30, 2022 07:55
@fruch fruch mentioned this pull request Jun 30, 2022
Merged
7 tasks
@fruch fruch requested a review from psarna June 30, 2022 07:56
vponomaryov
vponomaryov requested changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, leave only "keyspace" part of the change.
For full workability we will need the unreleased version of gocql with the following fix: scylladb/gocql#104

@fruch
Copy link
Contributor Author

fruch commented Sep 1, 2022

Please, leave only "keyspace" part of the change. For full workability we will need the unreleased version of gocql with the following fix: scylladb/gocql#104

I'm not sure how scylladb/gocql#104 is related to should we advance the version or not, why wouldn't we ?

if for testing specific fixes, we can build and test, i'm not following what do you mean here.

@vponomaryov
Copy link
Contributor

vponomaryov commented Sep 1, 2022 •
edited
Loading

Please, leave only "keyspace" part of the change. For full workability we will need the unreleased version of gocql with the following fix: scylladb/gocql#104

I'm not sure how scylladb/gocql#104 is related to should we advance the version or not, why wouldn't we ?

if for testing specific fixes, we can build and test, i'm not following what do you mean here.

At first, we will need the update after merge of the mentioned issue - it is for sure.
At second, such a change must be in a separate PR, because both existing commits are not dependant on each other.

@fruch
Copy link
Contributor Author

fruch commented Sep 1, 2022

Please, leave only "keyspace" part of the change. For full workability we will need the unreleased version of gocql with the following fix: scylladb/gocql#104

I'm not sure how scylladb/gocql#104 is related to should we advance the version or not, why wouldn't we ?
if for testing specific fixes, we can build and test, i'm not following what do you mean here.

At first, we will need the update after merge of the mentioned issue - it is for sure. At second, such a change must be in a separate PR, because both existing commits are not dependant on each other.

do you have any evidence this specific issue, part of what holding the retries

@vponomaryov
Copy link
Contributor

Please, leave only "keyspace" part of the change. For full workability we will need the unreleased version of gocql with the following fix: scylladb/gocql#104

I'm not sure how scylladb/gocql#104 is related to should we advance the version or not, why wouldn't we ?
if for testing specific fixes, we can build and test, i'm not following what do you mean here.

At first, we will need the update after merge of the mentioned issue - it is for sure. At second, such a change must be in a separate PR, because both existing commits are not dependant on each other.

do you have any evidence this specific issue, part of what holding the retries

https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/valerii/job/longevity-quorum-failure-reproducer-scylla-bench-small-partitions-3h/18/consoleFull

@fruch
use cluster.Keyspace before connecting to the nodes
fc04f78 
Seem what's described in apache/cassandra-gocql-driver#1621 might be
affecting us, and making scylla-bench send unblanced
traffic to scylla

REF: apache/cassandra-gocql-driver#1621
@roydahan roydahan merged commit e219321 into scylladb:master Sep 4, 2022
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Sep 5, 2022
@fruch
feature(scylla-bench): move to using scylla-bench==v0.1.9
9d16528 
* Add possibility to configure retry policy scylladb#96
* use cluster.Keyspace before connecting to the nodes scylladb#97

Ref: scylladb/scylla-bench#96
Ref: scylladb/scylla-bench#97
@fruch fruch mentioned this pull request Sep 5, 2022
Merged
7 tasks
fruch added a commit to scylladb/scylla-cluster-tests that referenced this pull request Sep 5, 2022
@fruch
feature(scylla-bench): move to using scylla-bench==v0.1.9
4d64ffd 
* Add possibility to configure retry policy #96
* use cluster.Keyspace before connecting to the nodes #97

Ref: scylladb/scylla-bench#96
Ref: scylladb/scylla-bench#97
vponomaryov added a commit to vponomaryov/scylla-bench that referenced this pull request Sep 7, 2022
@vponomaryov
fix: create 'scylla_bench' keyspace before it's usage
69de0fe 
In the PR [1] that was merged recently we started using
keyspace in the config object, but the code with it's creation
gets run after it's usage.

So, create the keyspace before it's usage to avoid failures on
clusters which do not have when 'scylla-bench' gets used.

[1] scylladb#97
@vponomaryov vponomaryov mentioned this pull request Sep 7, 2022
Merged
vponomaryov added a commit to vponomaryov/scylla-bench that referenced this pull request Sep 7, 2022
@vponomaryov
fix: create 'scylla_bench' keyspace before it's usage
c6118fb 
In the PR [1] that was merged recently we started using
keyspace in the config object, but the code with it's creation
gets run after it's usage.

So, create the keyspace before it's usage to avoid failures on
clusters which do not have when 'scylla-bench' gets used.

[1] scylladb#97
roydahan pushed a commit that referenced this pull request Sep 7, 2022
@vponomaryov @roydahan
fix: create 'scylla_bench' keyspace before it's usage
2e1bc33 
In the PR [1] that was merged recently we started using
keyspace in the config object, but the code with it's creation
gets run after it's usage.

So, create the keyspace before it's usage to avoid failures on
clusters which do not have when 'scylla-bench' gets used.

[1] #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roydahan roydahan roydahan approved these changes

@vponomaryov vponomaryov vponomaryov approved these changes

@psarna psarna Awaiting requested review from psarna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruch @vponomaryov @roydahan