Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Integrate login/signup and logout flow #44

Merged
merged 9 commits into from
May 14, 2020

Conversation

Ishan-002
Copy link
Member

@Ishan-002 Ishan-002 commented May 9, 2020

Closes #40

@Ishan-002 Ishan-002 linked an issue May 9, 2020 that may be closed by this pull request
@Ishan-002 Ishan-002 requested a review from ayanchoudhary May 9, 2020 13:32
@@ -1,3 +1,5 @@
export const CONFIG = {
nexusRoot: "http://localhost:8005/api/v1"
nexusRoot: "http://localhost:8005/api/v1",
arceusRoot: "http://arceus.sdslabs.local",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this in axion?

*
* @param {string} value
*/
log(value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a better function name

@Ishan-002 Ishan-002 requested a review from ayanchoudhary May 13, 2020 14:45
Copy link
Member

@ayanchoudhary ayanchoudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LQGTM

@ayanchoudhary ayanchoudhary merged commit 9ae5ac3 into development May 14, 2020
@ayanchoudhary ayanchoudhary deleted the integrate-login/signup/logout-flow branch May 14, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate login/signup and logout flow
2 participants