Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in the sdgym.run function docstring #69

Closed
sudarshan-koirala opened this issue Feb 24, 2021 · 0 comments · Fixed by #73
Closed

Typos in the sdgym.run function docstring #69

sudarshan-koirala opened this issue Feb 24, 2021 · 0 comments · Fixed by #73
Labels
documentation Docs, user guides or API
Milestone
0.3.1

Comments

@sudarshan-koirala
Copy link

sudarshan-koirala commented Feb 24, 2021 •
edited
Loading

  • SDGym version: 0.3.0

Description

There are some typos in docstring of the sdgym.run function
This is the exact url where there is typo -> Link

  • The argument show_progress defaults to False but mentioned that it defaults to True.
  • The argument iterations defaults to 1 but mentioned that it defaults to 3.
@sbrugman sbrugman mentioned this issue Apr 26, 2021
Merged
@csala csala closed this as completed in #73 May 17, 2021
csala pushed a commit that referenced this issue May 17, 2021
@sbrugman
fix: benchmark.run default value for parameters (#73)
e1e4aae 
* fix: benchmark.run default value for show_progress

* docs: ``iterations`` parameter defaults

`iterations`` parameter defaults in docstring. fixes #69
@csala csala added the documentation Docs, user guides or API label May 20, 2021
@csala csala added this to the 0.3.1 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Docs, user guides or API
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

fix: benchmark.run default value for parameters
2 participants
@csala @sudarshan-koirala