Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: add resource CRDs #2270

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat: add resource CRDs #2270

merged 2 commits into from
Apr 17, 2024

Conversation

alexcodelf
Copy link
Contributor

@alexcodelf alexcodelf commented Apr 11, 2024 •
edited
Loading

add Resource CRDs

@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 2 times, most recently from aaf0234 to da47103 Compare April 11, 2024 09:11
@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 2 times, most recently from 337dfb5 to d9fa877 Compare April 12, 2024 06:06
gitlawr
gitlawr reviewed Apr 12, 2024
View reviewed changes
pkg/apis/walruscore/v1/resource_components.go Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 4 times, most recently from 1d4c55d to 61b85e8 Compare April 15, 2024 02:54
thxCode
thxCode reviewed Apr 15, 2024
View reviewed changes
pkg/apis/walrus/v1/resource_components.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/connector.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/resource.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_components.go Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_components.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
pkg/controllers/walruscore/resource.go Outdated Show resolved Hide resolved
pkg/controllers/walruscore/resource.go Show resolved Hide resolved
pkg/controllers/walruscore/resource.go Show resolved Hide resolved
@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 2 times, most recently from 936e7a9 to bc3b542 Compare April 15, 2024 11:15
aiwantaozi
aiwantaozi reviewed Apr 16, 2024
View reviewed changes
pkg/apis/walruscore/v1/resource.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/template.go Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_run_template.go Outdated Show resolved Hide resolved
@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 2 times, most recently from 8ca21d1 to e4a7c6e Compare April 16, 2024 03:38
gitlawr
gitlawr reviewed Apr 16, 2024
View reviewed changes
pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
pkg/resources/api/resource_component.go Show resolved Hide resolved
@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 3 times, most recently from c03f03d to 124ae7e Compare April 17, 2024 02:44
@alexcodelf alexcodelf requested a review from thxCode April 17, 2024 02:45
@alexcodelf alexcodelf force-pushed the feat/k8s-resource branch 3 times, most recently from 0309739 to 5ab4cff Compare April 17, 2024 05:52
aiwantaozi
aiwantaozi reviewed Apr 17, 2024
View reviewed changes
pkg/apis/walruscore/v1/resource_components.go

// ComputedAttributes stores the computed attributes of the component.
// It stores the attributes of the resource that used to create the component.
ComputedAttributes runtime.RawExtension `json:"computedAttributes"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why resource ComponentsStatus need ComputedAttributes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce a 'true' attribute to map the components it creates. As the resource attributes modifications will generate multiple ResourceRuns, not all runs will implement the respective attributes. The resource or resource run attriubtes may not trully represents the resource components.

pkg/apis/walruscore/v1/resource_run.go Outdated Show resolved Hide resolved
thxCode
thxCode approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@thxCode thxCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aiwantaozi
aiwantaozi approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@aiwantaozi aiwantaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwantaozi aiwantaozi merged commit 9f9fc60 into seal-io:dev Apr 17, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gitlawr gitlawr gitlawr left review comments

@thxCode thxCode thxCode approved these changes

@aiwantaozi aiwantaozi aiwantaozi approved these changes

@shanewxy shanewxy Awaiting requested review from shanewxy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcodelf @thxCode @gitlawr @aiwantaozi