Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less 3.9 #13

Merged
merged 2 commits into from
Mar 23, 2019
Merged

Less 3.9 #13

merged 2 commits into from
Mar 23, 2019

Conversation

calvinjuarez
Copy link
Collaborator

Replaces #9 and #12, and updates #for-* mixin loops with each(range(@list)) allowed in 3.9. Also bumps required versions to 3.9. It bumps the npm package version to 0.4.0.

Thanks to @matthew-dean for the updates to the README and package.json that I stole from his PR.

This also fixes the issue where .table-responsive was being output out-of-order.

This changes the min required version of Less to v3.9 (to support range()).

@calvinjuarez calvinjuarez mentioned this pull request Dec 6, 2018
@seanCodes
Copy link
Owner

seanCodes commented Dec 6, 2018

@calvinjuarez Could you update this so that it doesn’t include any of the compiled CSS files? I'll compile them myself as part of the next version bump.'

Also rebase on top of the latest version, since I took care of the browserlist change and bumping Less to 3.9.0 with my most recent updates.

@calvinjuarez
Copy link
Collaborator Author

calvinjuarez commented Dec 7, 2018

This is dist/-free and ready to go.

@calvinjuarez calvinjuarez force-pushed the less3.9 branch 2 times, most recently from e7aed20 to 989bd2e Compare December 7, 2018 03:12
@matthew-dean matthew-dean mentioned this pull request Dec 9, 2018
@matthew-dean
Copy link

Should #14 be closed? I was confused and started commenting on that one, but I'm not sure what's happening here.

@seanCodes seanCodes merged commit a97b1a8 into seanCodes:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants