-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD: Add cpuset and physical core support #133
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Does our current CI handle this? If not, can we add a job?
f61e36d
to
efff545
Compare
@@ -150,6 +152,24 @@ jobs: | |||
rustup target add ${{ matrix.target }} | |||
cargo build --verbose --target ${{ matrix.target }} | |||
|
|||
test-freebsd: | |||
runs-on: macos-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: macos-12 | |
runs-on: ubuntu-latest |
Seems like the Ubuntu jobs are faster than mac (I assume there's a smaller quantity of them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately VM Actions only supports macos-12, as nested virtualisation isn't available elsewhere (at least on the free tier).
This adds support for retrieving the physical processor count by querying the
kern.smp.cores
sysctl, and also usescpuset_getaffinity
to determine the logical thread count. Both will fall back to the original code on failure.Tested on 13.1-RELEASE-p7/amd64.