This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
Uniform treatment of strings in Unicode. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idered in strings, which allows for matches in Cyrillic, Chinese, Greek, etc.
…unicode preprocessing *before* using fuzz lib.
…Also fixed empty string detection in token_sort_ratio.
|
Are all these commits supposed to be here? If so, I'll pester people at sg so that this gets merged where possible. (I'm one of the people you contacted on the 5th, sorry for the late reply!) |
|
Yes, they are, we are working together! No problem with the late reply. :) |
|
@acslater00 given our internal usage of fuzzywuzzy, does it make more sense to have functions like If so, I can work with @tlaunay to make the required changes. |
acslater00
pushed a commit
that referenced
this pull request
May 3, 2013
Pull Request #20 Augmented With force_ascii parameter
|
This was merged, thanks @tlaunay and @lerignoux for the pull request! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniform treatment of strings in Unicode. Non-ASCII chars are now considered in strings, which allows for matches in Cyrillic, Chinese, Greek, etc.
Also removed some unused imports and updated the tests.