Remove SFS specific views #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairstenfay
approved these changes
Jan 14, 2020
joverlee521
force-pushed
the
remove-sfs-views
branch
from
4878c3c to
7513f4c
Compare
These SFS specific shipping views will be ported over to ID3C-customizations. This schema change should be deployed with the sqitch's `--log-only` option since we don't actually want to drop these views from the database.
Remove the `drop view...` statements used for removing SFS specific from ID3C core. We do not want to include these statements in future shipping view reworks so that the SFS views are not dropped from the database.
tsibley
force-pushed
the
remove-sfs-views
branch
from
7513f4c to
9f86d97
Compare
tsibley
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the following SFS specific views from the core shipping views:
This will need to be deployed with the sqitch
--log-onlyoption since there are other views within ID3C customizations that depend on these views and we don't actually want to drop these views.