Add branch/path coverage to reports #761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #380
Hello @sebastianbergmann
This PR:
I've opted to use branch coverage rather than path coverage for that last metric because like line coverage, 100% branch coverage is realistically achievable whereas 100% path coverage for non-trivial functions is often not due to the exponential nature of paths. The large number of uncovered paths on such methods then has a disproportionate effect when summing up coverage on larger units like files and directories tending to mark them as uncovered even when most of the other methods and functions actually do have good coverage. This effect doesn't happen with branch coverage so I think it's a good middle ground between lines and paths and the CRAP score will still reveal the many-pathed functions as danger areas and good potential candidates for a refactoring.