-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate setMethods() #4775
Comments
sebastianbergmann
added
type/deprecation
Something will be/is deprecated
feature/test-doubles
Test Stubs and Mock Objects
and removed
type/bug
Something is broken
labels
Sep 25, 2022
sebastianbergmann
changed the title
Deprecated MockBuilder::setMethods does not throw a warning in PHPUnit 9
Deprecate setMethods()
Sep 25, 2022
Unfortunately, "soft deprecation" (annotating the methods in question with |
sebastianbergmann
removed
feature/test-doubles
Test Stubs and Mock Objects
type/deprecation
Something will be/is deprecated
labels
Jan 14, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Working on adjusting Drupal for PHPUnit 10, I realized
MockBuilder::setMethods
is removed from PHPUnit 10. Unlike other methods deprecated in PHPUnit 8 and 9, there's no warning thrown about the deprecation.Since in Drupal we rely on deprecation errors being triggered, so far this deprecation was missed from any conversion.
Current behavior
n/a
How to reproduce
n/a
Expected behavior
I suppose a Warning should be thrown in PHPUnit 9, on top of the annotated deprecation.
The text was updated successfully, but these errors were encountered: