Add warning to MockBuilder::setMethods() about deprecated method #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 9.5 #4803 +/- ##
=========================================
Coverage 83.79% 83.79%
Complexity 4596 4596
=========================================
Files 273 273
Lines 11435 11435
=========================================
Hits 9582 9582
Misses 1853 1853
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sebastianbergmann
added
type/deprecation
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my very first PR to the PHPUnit project, so any suggestions are welcomed.
These changes are referring to the #4775 issue. Until now, there is no warning about the deprecated
setMethods()method.Problem I had was that
TestCase::createPartialMock()still usingMockBuilder::setMethods()and I'm not sure if it's possible to refactor code to useonlyMethods()&addMethods()instead. I decided to exclude warning for this specific use case.