Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty coverage tag when migrationg phpunit.xml https://github.com/sebastianbergmann/phpunit/issues/5612 #5626

Conversation

marac19901990
Copy link
Contributor

Remove empty coverage tag generated during migration of phpunit.xml
psalm check done,
php-cs-fixer done,
fixed tests after changes

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6d16518) 89.11% compared to head (d85629b) 89.11%.

Files Patch % Lines
...ml/Migration/Migrations/RemoveEmptyCoverageTag.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               10.5    #5626      +/-   ##
============================================
- Coverage     89.11%   89.11%   -0.01%     
- Complexity     6382     6386       +4     
============================================
  Files           673      674       +1     
  Lines         20355    20362       +7     
============================================
+ Hits          18139    18145       +6     
- Misses         2216     2217       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

@marac19901990 marac19901990 deleted the 10.5-migration-improvement branch December 28, 2023 10:06
@marac19901990
Copy link
Contributor Author

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

No problem, I don't see it assomething important either :D Hope you will allow me to help with more serious tasks, I'm just about to make a pull request. All the best :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants