Add double and float parsers #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
reviewed
Feb 15, 2024
src/Parlot/Fluent/Parsers.cs
Outdated
| /// <summary> | ||
| /// Builds a parser that matches a floating point number represented as a <lang cref="float"/> value. | ||
| /// </summary> | ||
| public Parser<float> Float() => new FloatLiteral(); |
There was a problem hiding this comment.
I don't know how often these get called, but could also return FloatLiteral.Default which is internal readonly static field if these don't have state
There was a problem hiding this comment.
A static instance would work, but it's only created a few times in a parser. I am not even sure you would call the same "Float" in multiple places, for instance you'd have a single higher level parser which would use it, like a PrimaryExpression made of integers, floats, strings ...
So I don't think it's worth it. I'll check others though.
sebastienros
force-pushed
the
sebros/floats
branch
from
082b8a6
to
9cb6ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.