Begin all transaction asyncronasley

sebastienros · Nov 14, 2023 · fd9f614 · fd9f614
1 parent c3c962f
commit fd9f614
Show file tree

Hide file tree

Showing 13 changed files with 43 additions and 43 deletions.
diff --git a/samples/YesSql.Bench/Program.cs b/samples/YesSql.Bench/Program.cs
@@ -23,7 +23,7 @@ static async Task MainAsync(string[] args)
             {
                 await connection.OpenAsync();
 
-                await using var transaction = connection.BeginTransaction(configuration.IsolationLevel);
+                await using var transaction = await connection.BeginTransactionAsync(configuration.IsolationLevel);
                 var builder = new SchemaBuilder(configuration, transaction);
 
                 await builder.CreateMapIndexTableAsync<UserByName>(c => c

diff --git a/samples/YesSql.Samples.FullText/Program.cs b/samples/YesSql.Samples.FullText/Program.cs
@@ -29,7 +29,7 @@ public static async Task Main(string[] args)
             {
                 await connection.OpenAsync();
 
-                await using var transaction = connection.BeginTransaction(store.Configuration.IsolationLevel);
+                await using var transaction = await connection.BeginTransactionAsync(store.Configuration.IsolationLevel);
                 var builder = new SchemaBuilder(store.Configuration, transaction);
 
                 await builder.CreateReduceIndexTableAsync<ArticleByWord>(table => table

diff --git a/samples/YesSql.Samples.Hi/Program.cs b/samples/YesSql.Samples.Hi/Program.cs
@@ -26,7 +26,7 @@ static async Task MainAsync(string[] args)
             {
                 await connection.OpenAsync();
 
-                await using var transaction = connection.BeginTransaction(store.Configuration.IsolationLevel);
+                await using var transaction = await connection.BeginTransactionAsync(store.Configuration.IsolationLevel);
                 var builder = new SchemaBuilder(store.Configuration, transaction);
 
                 await builder.CreateMapIndexTableAsync<BlogPostByAuthor>(table => table

diff --git a/samples/YesSql.Samples.Performance/Benchmarks.cs b/samples/YesSql.Samples.Performance/Benchmarks.cs
@@ -35,7 +35,7 @@ private async Task InitializeAsync()
                 await using var connection = configuration.ConnectionFactory.CreateConnection();
                 await connection.OpenAsync();
 
-                await using var transaction = connection.BeginTransaction();
+                await using var transaction = await connection.BeginTransactionAsync();
                 var builder = new SchemaBuilder(configuration, transaction);
 
                 await builder.DropTableAsync("UserByName");
@@ -52,7 +52,7 @@ private async Task InitializeAsync()
             {
                 await connection.OpenAsync();
 
-                await using var transaction = connection.BeginTransaction();
+                await using var transaction = await connection.BeginTransactionAsync();
                 var builder = new SchemaBuilder(configuration, transaction);
 
                 await builder.CreateMapIndexTableAsync<UserByName>(table => table

diff --git a/samples/YesSql.Samples.Web/Program.cs b/samples/YesSql.Samples.Web/Program.cs
@@ -132,7 +132,7 @@
 await using var connection = store.Configuration.ConnectionFactory.CreateConnection();
 await connection.OpenAsync();
 
-await using var transaction = connection.BeginTransaction(store.Configuration.IsolationLevel);
+await using var transaction = await connection.BeginTransactionAsync(store.Configuration.IsolationLevel);
 var schemaBuilder = new SchemaBuilder(store.Configuration, transaction);
 
 await schemaBuilder.CreateMapIndexTableAsync<BlogPostIndex>(table => table

diff --git a/src/YesSql.Core/Services/DbBlockIdGenerator.cs b/src/YesSql.Core/Services/DbBlockIdGenerator.cs
@@ -117,7 +117,7 @@ private async Task LeaseRangeAsync(Range range)
                 // Ensure we overwrite the value that has been read by this
                 // instance in case another client is trying to lease a range
                 // at the same time
-                await using (var transaction = connection.BeginTransaction(System.Data.IsolationLevel.ReadCommitted))
+                await using (var transaction = await connection.BeginTransactionAsync(System.Data.IsolationLevel.ReadCommitted))
                 {
                     try
                     {
@@ -195,7 +195,7 @@ public async Task InitializeCollectionAsync(IConfiguration configuration, string
             await using var connection = configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using (var transaction = connection.BeginTransaction(configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(configuration.IsolationLevel))
             {
                 // Does the record already exist?
                 var selectCommand = transaction.Connection.CreateCommand();
@@ -223,7 +223,7 @@ public async Task InitializeCollectionAsync(IConfiguration configuration, string
                 // Try to create a new record. If it fails, retry reading the record.
                 try
                 {
-                    await using var transaction = connection.BeginTransaction(configuration.IsolationLevel);
+                    await using var transaction = await connection.BeginTransactionAsync(configuration.IsolationLevel);
                     // To prevent concurrency issues when creating this record (it must be unique)
                     // we generate a random collection name, then update it safely
 

diff --git a/src/YesSql.Core/Services/DefaultIdGenerator.cs b/src/YesSql.Core/Services/DefaultIdGenerator.cs
@@ -53,7 +53,7 @@ public async Task InitializeCollectionAsync(IConfiguration configuration, string
             await using var connection = configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(configuration.IsolationLevel);
             var tableName = configuration.TableNameConvention.GetDocumentTable(collection);
 
             var sql = "SELECT MAX(" + _dialect.QuoteForColumnName("Id") + ") FROM " + _dialect.QuoteForTableName(configuration.TablePrefix + tableName, configuration.Schema);

diff --git a/src/YesSql.Core/Store.cs b/src/YesSql.Core/Store.cs
@@ -95,7 +95,7 @@ public async Task InitializeAsync()
                 {
                     await connection.OpenAsync();
 
-                    await using var transaction = connection.BeginTransaction(Configuration.IsolationLevel);
+                    await using var transaction = await connection.BeginTransactionAsync(Configuration.IsolationLevel);
 
                     var builder = new SchemaBuilder(Configuration, transaction);
 
@@ -144,7 +144,7 @@ public async Task InitializeCollectionAsync(string collection)
                     catch
                     {
                         await result.CloseAsync();
-                        await using var migrationTransaction = connection.BeginTransaction();
+                        await using var migrationTransaction = await connection.BeginTransactionAsync();
                         var migrationBuilder = new SchemaBuilder(Configuration, migrationTransaction);
 
                         try
@@ -166,7 +166,7 @@ await migrationBuilder.AlterTableAsync(documentTable, table => table
             }
             catch
             {
-                await using var transaction = connection.BeginTransaction();
+                await using var transaction = await connection.BeginTransactionAsync();
                 var builder = new SchemaBuilder(Configuration, transaction);
 
                 try

diff --git a/test/YesSql.Tests/CoreTests.cs b/test/YesSql.Tests/CoreTests.cs
@@ -81,7 +81,7 @@ protected virtual async Task CleanDatabaseAsync(IConfiguration configuration, bo
             await using var connection = configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(configuration.IsolationLevel);
             var builder = new SchemaBuilder(configuration, transaction, throwOnError);
 
             await builder.DropReduceIndexTableAsync<ArticlesByDay>();
@@ -208,7 +208,7 @@ public async Task CreateTablesAsync(IConfiguration configuration)
             await using var connection = configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(configuration.IsolationLevel);
             var builder = new SchemaBuilder(configuration, transaction);
 
             await builder.CreateReduceIndexTableAsync<ArticlesByDay>(column => column
@@ -5211,7 +5211,7 @@ public virtual async Task ShouldRenameColumn()
 
             try
             {
-                await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+                await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
 
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 
@@ -5224,7 +5224,7 @@ public virtual async Task ShouldRenameColumn()
                 // Do nothing if the table can't be dropped
             }
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 
@@ -5243,7 +5243,7 @@ await builder.CreateTableAsync(table, column => column
                 await transaction.CommitAsync();
             }
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var sqlSelect = string.Format("SELECT {0} FROM {1}",
                     _store.Configuration.SqlDialect.QuoteForColumnName(column1),
@@ -5257,7 +5257,7 @@ await builder.CreateTableAsync(table, column => column
                 await transaction.CommitAsync();
             }
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 
@@ -5268,7 +5268,7 @@ await builder.AlterTableAsync(table, column => column
                 await transaction.CommitAsync();
             }
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var sqlSelect = string.Format("SELECT {0} FROM {1}",
                     _store.Configuration.SqlDialect.QuoteForColumnName(column2),
@@ -5508,7 +5508,7 @@ public async Task ShouldCreateAndIndexPropertyWithMaximumKeyLengths()
             {
                 await connection.OpenAsync();
 
-                await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+                await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 
                 await builder.DropMapIndexTableAsync<PropertyIndex>();

diff --git a/test/YesSql.Tests/MySqlTests.cs b/test/YesSql.Tests/MySqlTests.cs
@@ -73,7 +73,7 @@ public async Task ThrowsWhenIndexKeyLengthExceeded()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder.DropMapIndexTableAsync<PropertyIndex>();
@@ -99,7 +99,7 @@ public async Task ShouldCreatePropertyIndexWithSpecifiedLength()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder.DropMapIndexTableAsync<PropertyIndex>();
@@ -125,7 +125,7 @@ public async Task ThrowsWhenIndexKeysWithBitsLengthExceeded()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder.DropMapIndexTableAsync<PropertyIndex>();
@@ -150,7 +150,7 @@ public async Task ThrowsWhenIndexKeysLengthExceeded()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder.DropMapIndexTableAsync<PropertyIndex>();
@@ -173,7 +173,7 @@ public async Task ShouldCreatePropertyIndexWithMaxKey()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder.DropMapIndexTableAsync<PropertyIndex>();
@@ -197,7 +197,7 @@ public async Task ShouldCreateIndexPropertyWithMaxKeys()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder.DropMapIndexTableAsync<PropertyIndex>();
@@ -223,7 +223,7 @@ public async Task ShouldCreateIndexPropertyWithMaxBitKeys()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel);
+            await using var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel);
             var builder = new SchemaBuilder(_store.Configuration, transaction);
 
             await builder
@@ -252,7 +252,7 @@ public async Task ShouldCreateHashedIndexKeyName()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 
@@ -267,7 +267,7 @@ await builder.CreateReduceIndexTableAsync<PersonsByNameCol>(column => column
                 await transaction.CommitAsync();
             }
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 

diff --git a/test/YesSql.Tests/PostgreSqlTests.cs b/test/YesSql.Tests/PostgreSqlTests.cs
@@ -45,7 +45,7 @@ public async Task ShouldIndexPropertyKeys()
             {
                 await connection.OpenAsync();
 
-                await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+                await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
                 {
                     var builder = new SchemaBuilder(_store.Configuration, transaction);
 
@@ -54,7 +54,7 @@ public async Task ShouldIndexPropertyKeys()
                     await transaction.CommitAsync();
                 }
 
-                await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+                await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
                 {
                     var builder = new SchemaBuilder(_store.Configuration, transaction);
                     await builder
@@ -97,7 +97,7 @@ public async Task ShouldCreateHashedIndexKeyName()
             await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
             await connection.OpenAsync();
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var builder = new SchemaBuilder(_store.Configuration, transaction);
 
@@ -110,7 +110,7 @@ await builder.CreateReduceIndexTableAsync<PersonsByNameCol>(column => column
                 await transaction.CommitAsync();
             }
 
-            await using (var transaction = connection.BeginTransaction(_store.Configuration.IsolationLevel))
+            await using (var transaction = await connection.BeginTransactionAsync(_store.Configuration.IsolationLevel))
             {
                 var builder = new SchemaBuilder(_store.Configuration, transaction);