Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distinct usage in queries #432

Merged
merged 12 commits into from
Dec 3, 2022
Merged

Remove distinct usage in queries #432

merged 12 commits into from
Dec 3, 2022

Conversation

sebastienros
Copy link
Owner

No description provided.

@deanmarcussen
Copy link
Collaborator

Nice. Aggregates look like a good addition too

@sebastienros
Copy link
Owner Author

It's just to fix a bug actually, and some perf issues :/
When an index has multiple values for the same document you can't order by something in the index unless there is an aggregate. And this PR is also removing the DISTINCT and replaces it with a GROUP BY for perf reasons.

@Piedone
Copy link
Contributor

Piedone commented Aug 31, 2022

Fixes #428?

# Conflicts:
#	src/YesSql.Core/Services/DefaultQuery.cs
#	src/YesSql.Provider.PostgreSql/PostgreSqlDialect.cs
#	src/YesSql.Provider.SqlServer/SqlServerDialect.cs
#	test/YesSql.Tests/SqlServer2019Tests.cs
@sebastienros sebastienros merged commit aa87d8f into main Dec 3, 2022
@sebastienros sebastienros deleted the sebros/distinct branch December 3, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants