fixes offset limit duplication fo sqlServer #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoAltinet
changed the title
hishamco
suggested changes
Jul 25, 2023
| @@ -2914,6 +2914,9 @@ public async Task ShouldPageResults() | |||
| { | |||
| Assert.Equal(1, String.Compare(ordered[i].SomeName, ordered[i - 1].SomeName)); | |||
| } | |||
|
|
|||
| //query should discard previous skip/take | |||
| Assert.Equal(5, (await query.Skip(10).Take(5).ListAsync()).Count()); | |||
There was a problem hiding this comment.
Can we create a new test for this?
Co-authored-by: Hisham Bin Ateya <[email protected]>
sebastienros
added a commit
that referenced
this pull request
Oct 11, 2023
This reverts commit f4a680b.
sebastienros
added a commit
that referenced
this pull request
Oct 11, 2023
|
I reverted it since it was failing the PostgreSQL tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes when different skip/take is used on a same query
Fixes #433
often a case when doing batching