Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for some more errors (syscall errors and DNS specifically) #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpittner
Copy link

What: add some more error types based (syscall errors and DNS specifically) on information outlined here: https://haisum.github.io/2021/08/14/2021-golang-http-errors/

This is probably less useful for recording, but quite handy for mutating responses when injecting errors for testing.

@dpittner dpittner marked this pull request as ready for review November 25, 2024 17:39
@seborama
Copy link
Owner

Hey, thanks @dpittner 👍
I'm quite busy professionally and personally right this moment but I'll take a look at your PR as soon as I can.
Many thanks and regards!

@seborama
Copy link
Owner

It turns out, this is a really clearly laid out PR and I was able to review it right away.
Thanks for your help with this project. I really appreciate the time you spent to help improve it.
I hope you're enjoying govcr!
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants