Support pure python Ed25519 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These optional requirements should make it so that a default installation can verify ed25519 signatures in pure python Signed-off-by: Vladimir Diaz <[email protected]>
Importing keys.py shouldn't raise ImportError for missing crypto libraries Signed-off-by: Vladimir Diaz <[email protected]>
This was referenced May 18, 2018
The unit tests expect all requirements to be installed, so add pragma statements to ignore import failures Signed-off-by: Vladimir Diaz <[email protected]>
|
Hi @vladimir-v-diaz, this seems to work, thanks! Unfortunately, in-toto requires |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Addresses theupdateframework/python-tuf#727.
Description of the changes being introduced by the pull request:
This pull request makes
cryptography,colorama, andpynacloptional dependencies. A default installation of securesystemslib (and TUF) is expected to work in pure Python and verify Ed25519 signatures. Users who wish to fully support RSA, ECDSA, and the repo tools must install the optional dependencies.pip install securesystemslib['crypto']andpip install securesystemslib['pynacl']).Please verify and check that the pull request fulfills the following
requirements:
Signed-off-by: Vladimir Diaz <[email protected]>