Add default timeout setting helper to process module #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper to use settings.SUBPROCESS_TIMEOUT as default argument in process.run* functions, but still be able to modify the setting after the function definitions are evaluated, i.e. when the process module is first imported.
|
@adityasaky, would you mind reviewing this PR? |
|
This looks like a nice change to me. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
None
Description of the changes being introduced by the pull request:
Add helper to use
settings.SUBPROCESS_TIMEOUTas default argument inprocess.run*functions, and still be able to modify the setting in the settingsmodule after the function definitions are evaluated, i.e. after the process module is imported for the first time.Please verify and check that the pull request fulfils the following
requirements: