github: Add workflow to check ed25519 upstream #294
Conversation
|
I did this as much to understand github workflows as for the actual purpose of having the automated upstream check -- so if you don't like it feel free to complain :) Making this a github workflow seemed like more useful than a travis job: now it does not block other PRs and actually opens the issue which is what we want |
|
I think I'll move the shell script to |
jku
force-pushed
the
check-upstream-ed25519
branch
from
6a362bd to
6a5bee8
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
for those not familiar with Github actions: this uses-line refers to the Github repository "actions/checkout", where actions is an official Github organization -- so I'm not using any random action-repos here.
| }) | ||
|
|
||
| if (issues.data.total_count > 0) { | ||
| console.log("Issue is already open, not creating.") |
There was a problem hiding this comment.
Where do these log messages go?
There was a problem hiding this comment.
You can get to them from the actions tab, here's an example where master had changed but an open issue was already found: https://github.com/jku/securesystemslib/runs/1321303954
securesystemslib includes a vendored copy of https://github.com/pyca/ed25519.git . The upstream is not a very lively project by any means but we would like to know if something happens there (like a bug fix). * Add a script that checks if upstream master HEAD is unchanged (the expected commit is in the script) * Add a github workflow that once a day files an issue if the upstream master head has changed and if an issue is not open yet
jku
force-pushed
the
check-upstream-ed25519
branch
from
6a5bee8 to
639c9ea
Compare
|
Amended the commit with suggested string fixes (thanks) and a whitespace fix. |
|
we should see if it works in about 50 minutes since ed25519 has today had its first commits in 7 years :) |
securesystemslib includes a vendored copy of https://github.com/pyca/ed25519.git . The upstream is not a very lively project by any means but we would like to know if something ever happens there (like a bug fix).
a) specifying the expected hash in git
b) running the check on developers machine
The opened issue looks like this jku#3. I've tested this in my repo but unfortunately I think it won't be possible to test the workflow in securesystemslib repo before the file exists in master branch (after it exists, the workflow can be executed manually even from a branch).