Better ed25519 upstream reporting, update expected commit #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
reviewed
Jan 15, 2021
added 2 commits
January 15, 2021 17:44
* Include the script output in filed bug report * Make sure the output includes expected and found hash, as well as links to current master and a diff * Just use bash features for string mangling
This change in ed25519 is an infrastructure change only: no need to update. Fixes secure-systems-lab#305
jku
force-pushed
the
better-ed25519-reporting
branch
from
ffc106c to
cd841cd
Compare
|
Did (something like) what Lukas suggested: the script output is now a bit gibberish in shell but this way the issue looks ok: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #305
Improve the bug report we get on upstream ed25519 changes, update the current expected hash.
Issue now looks like this: jku#5