Catch timeouts on import of gpg.constants #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, in some systems, not pointing any fingers but Windows, just finding out that there's no `gpg` available takes >3 seconds. In that case, we now just assume that there's no GPG because a binary that takes 3 seconds even to start isn't any better than no binary at all. Fixes secure-systems-lab#428. Signed-off-by: Zachary Newman <[email protected]>
|
CI failures are because the subprocess module isn't imported in gpg.constants. I don't know why this only fails on macOS 😕 |
|
Yeah, that's...bizarre. I don't think we're going to merge this (see discussion in the linked bug) but that might point to some issue in tests. CC @adityasaky |
|
Oh! The try:
pass
except ThisExceptionDoeNotExistwill always succeed |
|
Of course, that does suggest we might need more comprehensive CI. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, in some systems, not pointing any fingers but Windows, just finding out that there's no
gpgavailable takes >3 seconds.In that case, we now just assume that there's no GPG because a binary that takes 3 seconds even to start isn't any better than no binary at all.
Fixes #428.
Signed-off-by: Zachary Newman [email protected]