Remove all python shebang instances from package #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup from work in secure-systems-lab#544 and secure-systems-lab#498 Other instances are in diff files, actual generated python code, or unrelated to python shebang instances
|
Thanks for the patch, @ckilcoin! I'd appreciate a short comment on why it's okay to remove all these shebang lines. |
lukpueh
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Lines can be removed since Python2 support has been deprecated and all modules work with Python3 and do not need to specify which python instance to use.
Thanks for adding the comment. I was actually looking for something like... the relevant modules are generally imported from other modules and not run as script and the tests may very well be executed by specifying the interpreter explicitly, if executed individually...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #544 and #498
Other instances are in diff files, actual generated python code, or unrelated to python shebang instances
Followup from discussion / work in #544 and #498
Lines can be removed since Python2 support has been deprecated and all modules work with Python3 and do not need to specify which python instance to use.
Please verify and check that the pull request fulfils the following requirements: