signer API: test key loading and signature verification more thoroughly #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make table driven, in order test other key types and signing schemes more easily. Signed-off-by: Lukas Puehringer <[email protected]>
This test adds pre-generated signatures and public keys to test all traditional signing schemes, i.e. everything that is supported by SSlibKey except for sphincs+ schemes. Signed-off-by: Lukas Puehringer <[email protected]>
jku
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-generated public keys and signatures for all traditional1 signing schemes and test loading with Key.from_dict and verification
Footnotes
All schemes supported by securesystemslib.verify_signature, except for very old schemes (
*md5,*sha1-- see Drop md5 and sha1 schemes from supported key schemes #512) or very new schemes (sphincs+-- will be tested more through separatelty ). ↩