Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable widths & themes #107

Merged
merged 8 commits into from
Dec 19, 2019
Merged

Conversation

michaeltaranto
Copy link
Contributor

This PR adds the ability to configure which themes and widths are viewable, and store them as a local user preference. In addition this preference is encoded in the url, so when sharing a link, consumers see the same setup as the author.

Also note, with the addition of a toolbar to house the preference menus, we have removed the option to left dock the editor. It already felt strange, but with these new features it really detracted from the overall experience of the preview and code taken precedence.

Features

  • Configurable themes & widths as user preference
  • Configurable themes & widths in share url
  • Removed left docked editor option

Bug Fixes

  • Changed order of webpack module resolution extensions array:
-['.mjs', '.js', '.json', '.ts', '.tsx']
+['.tsx', '.ts', '.jsx', '.js', '.json']

Should fix #105.

Refactor

  • Hoisted fonts, colours, shadows, etc into top level theme/variables.

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👏👏👏

@michaeltaranto michaeltaranto merged commit 76d575b into master Dec 19, 2019
@michaeltaranto michaeltaranto deleted the configurable-widths-themes branch December 19, 2019 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.11.2 breaks webpackConfig.resolve.extensions
3 participants