-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates, bump jest maxWorkers
to 3
#835
Conversation
🦋 Changeset detectedLatest commit: ce19958 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge issue, but I would mark these changes as minor
. I would say the removal of code falls in the same category as adding code.
Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. We would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment.
I'm not too fussed about the semantics, though. Feel free to leave it as is if you disagree.
Split out the changeset into two separate ones: one for dep updates, and the other for the dep removal. Also snuck in a |
babel-plugin-dynamic-import-node
. This plugin was only being used in jest, i.e. Node, but dynamic import has been supported in Node since 13.2.0, so there's no need to transform it anymore.less-loader
version, primarily to prevent consumers getting locked to a version without this fix that removed an unused, very old dependency that ended up including various old versions of things, as well asnode-gyp
innode_modules
🙅node-emoji
to the latest major version. Was waiting for them to release my change.maxWorkers
to 3 on CI as the macos github agents have 3 cores, so we might as well use them. Looks like we can get <5 minute test runs on CI pretty consistently now. This will go away if we eventually move back to ubuntu images, but it's nice to have for now.