Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates, bump jest maxWorkers to 3 #835

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Jun 9, 2023

@askoufis askoufis requested a review from a team as a code owner June 9, 2023 06:15
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

🦋 Changeset detected

Latest commit: ce19958

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@mrm007 mrm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge issue, but I would mark these changes as minor. I would say the removal of code falls in the same category as adding code.

Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. We would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment.

I'm not too fussed about the semantics, though. Feel free to leave it as is if you disagree.

@askoufis
Copy link
Contributor Author

Not a huge issue, but I would mark these changes as minor. I would say the removal of code falls in the same category as adding code.

Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. We would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment.

I'm not too fussed about the semantics, though. Feel free to leave it as is if you disagree.

Split out the changeset into two separate ones: one for dep updates, and the other for the dep removal. Also snuck in a node-emoji update too since they finally released a new version.

@askoufis askoufis merged commit 87a59c9 into master Jun 19, 2023
@askoufis askoufis deleted the bits-and-bobs branch June 19, 2023 00:29
@seek-oss-ci seek-oss-ci mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants