Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybind_profile_NR setting in config.json is missing #3323

Closed
2 tasks done
DominikStyp opened this issue Oct 29, 2024 · 5 comments
Closed
2 tasks done

keybind_profile_NR setting in config.json is missing #3323

DominikStyp opened this issue Oct 29, 2024 · 5 comments
Labels

Comments

@DominikStyp
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

No, only missing useful setting.

Describe the solution you'd like

You did introduce "keybind_profile": 109, setting which is really cool, but there's missing "keybind_profile_X", so for example if I add a custom setting like:

 "mode_base_4": 0,
  "mode_name_4": "QuietCool",
  "fan_profile_mid_4": "1E-32-3C-41-46-50-55-5A-00-00-00-07-15-32-45-58",
  "fan_profile_cpu_4": "1E-32-37-3C-46-4B-50-5A-00-01-02-0B-1C-3B-46-5B",
  "fan_profile_gpu_4": "1E-28-2D-32-3C-4B-50-5A-00-00-03-05-09-29-3B-50",
  "limit_total_4": 75,
  "limit_slow_4": 125,
  "limit_cpu_4": 50,
  "limit_fast_4": 125,
  "auto_apply_power_4": 1,
  "auto_apply_4": 1,
  "auto_boost_4": 3,

I would also like to add "keybind_profile_4": 109, which should switch to mode nr 4 when I click CTRL + SHIFT + ALT + KEY.
It should be fairly simple, no?

Describe alternatives you've considered

No response

Device and Model

ROG STRIX SCAR 18 (2023) G834JY

Additional information.

No response

@seerge
Copy link
Owner

seerge commented Oct 29, 2024

@DominikStyp hello, you already have those , so it's possible to set profiles from a custom hotkey.

Ctrl + Shift + Alt + F16 - Silent
Ctrl + Shift + Alt + F17 - Balanced
Ctrl + Shift + Alt + F18 - Turbo
Ctrl + Shift + Alt + F19 - Custom 1 (if exists)
Ctrl + Shift + Alt + F20 - Custom 2 (if exists)

Just use Sharpkeys or Autohotkey to bind your own hotkey to emit Ctrl + Shift + Alt + F20 and it will work

@DominikStyp
Copy link
Author

@seerge well this is not really convenient to install additional programs to just remap some combinations if this could just be a part of the UI or config, but if you really don't want to spend the time on that, OK I get it.

@seerge
Copy link
Owner

seerge commented Oct 29, 2024

@DominikStyp if every small thing that people ask will be part of the UI - UI will look like a Boeing cockpit :) It's already very difficult to keep things simple and relatively organized.

You already have quite a lot of flexibility in terms of profile switching (FN+F5 and FN+SHIFT+F5 to cycle through them forwards and backwards).

This special hotkeys are mainly designed for exotic use-cases where you need to set specific profile instantly. For example for game launchers like Playnite or so.

seerge added a commit that referenced this issue Oct 29, 2024
@seerge
Copy link
Owner

seerge commented Oct 29, 2024

@DominikStyp I have thought about it a bit, and did some tweaks so it should be possible to set key bindings for the first 5 profiles (from 0 to 4) - keybind_profile_0 .. keybind_profile_4 in the app now.

Don't forget that 0 = Balanced, 1 = Turbo and 2 = Silent (this is native Asus enumeration)

Try this build

GHelper.zip

@DominikStyp
Copy link
Author

@seerge thanks I already handled my case by AutoHotkey custom send scripts, I need to programatically change the G-Helper profiles, because I'm building custom solution to change the profile depending on the CPU usage, so when CPU load is small it will change the profile to Silent, if CPU has high load it will change it to Turbo or custom with increased fan speeds.
I'll check your build tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants