Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHelper auto update fails to extract and start new version #3568

Closed
2 tasks done
ghost-of-cerberus opened this issue Jan 7, 2025 · 10 comments
Closed
2 tasks done

GHelper auto update fails to extract and start new version #3568

ghost-of-cerberus opened this issue Jan 7, 2025 · 10 comments
Labels
question Further information is requested

Comments

@ghost-of-cerberus
Copy link

ghost-of-cerberus commented Jan 7, 2025

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information or no app logs will be provided, my issue will be closed without an answer.

What's wrong?

GHelper auto update doesn't work if installed in a location with special characters in the path.

How to reproduce the bug?

  1. Download latest release
  2. Unzip to a folder containing allowable special characters in the path (i.e., [ ] . _ etc) (e.g., C:\Users\joebloggs\[_special]\GHelper)
  3. Run GHelper.exe
  4. When notified and prompted to download a new g-helper release, select yes/okay

At this point, the new version of GHelper is downloaded to the executable folder and the running version is closed but is not replaced or restarted.

Logs

log.txt

Device and Model

ASUS ROG Zephyrus G14 GA402XZ

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

0

Version

0.200

OS

Windows 11 Pro 23H2

@seerge
Copy link
Owner

seerge commented Jan 7, 2025

@ghost-of-cerberus hello, can you check if this build correctly prompts for an update and updates itself ? (it has "fake" version number in order to trigger update)

GHelper.zip

@ghost-of-cerberus
Copy link
Author

@seerge hi. Tried it but it takes a bit to load and doesn't prompt to update. Tried a few times.

Version displayed in the app is 0.200.

log.txt

Should I try with a clean config?

@seerge
Copy link
Owner

seerge commented Jan 8, 2025

@ghost-of-cerberus ok, my bad. By some reason it was compiled with the latest version :)

Try this build instead.

GHelper.zip

I have also added an automatic restart with admin-permission on Auto Update if folder containing GHelper.exe requires them (like C:\Program Files\GHelper as some people do)

@osomat123 - you can also try this build, it should work for your case too :)

Thanks

@seerge seerge added the question Further information is requested label Jan 8, 2025
@ghost-of-cerberus
Copy link
Author

@seerge no worries. :)

Tried the new build and received the following results:

Test Description Result Comment
Existing path in logs Success
Test including --_!$%^&()=+,.';#~{} in path Failed New version downloaded but not installed/started
Test including Unicode characters in path Success
Test secure path requiring admin privileges Failed Prompted for admin credentials when approving update. GHelper closes and reopens but does not download update. Prompts to upgrade again immediately on reload.

Relevant logs: log.txt

Same device and configuration as initial report.

Thanks!

@seerge
Copy link
Owner

seerge commented Jan 8, 2025

@ghost-of-cerberus

For --_!$%^&()=+,.';#~{} the ' symbol was a problem, it has to be escaped as well.

For admin privileges I didn't plan to add automatic download past restart with them. So actually app acts as expected, it offers to update again (but this time with admin rights, so it will work)

However I have changed this, and now it will run update process immediately after restarting as admin.

Try this build
GHelper.zip

seerge added a commit that referenced this issue Jan 8, 2025
@ghost-of-cerberus
Copy link
Author

@seerge interestingly, the ANSI/ASCII special characters path and normal path tests are the only ones that work now.

The Unicode and admin access tests appear to download the new version but fails to extract the new version and just deletes the download.

log.txt

Cheers!

seerge added a commit that referenced this issue Jan 8, 2025
@seerge
Copy link
Owner

seerge commented Jan 8, 2025

@ghost-of-cerberus hello,

Can you check this build ? For me it works in all 3 "exotic" cases
<anything>\TEST--😒⌛
<anything>\--_!$%^&()=+,.';#~{}
C:\Program Files\GHelper

GHelper.zip

Thanks

@ghost-of-cerberus
Copy link
Author

ghost-of-cerberus commented Jan 8, 2025

@seerge Also works for me in all three instances.

Thanks for the work on this!

@seerge
Copy link
Owner

seerge commented Jan 8, 2025

@ghost-of-cerberus finally :) Thanks for a detailed testing!

@seerge seerge closed this as completed Jan 8, 2025
@ghost-of-cerberus
Copy link
Author

@seerge no worries. Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants