Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

improve error message for changed password? #127

Closed
bazzargh opened this issue Mar 4, 2019 · 2 comments
Closed

improve error message for changed password? #127

bazzargh opened this issue Mar 4, 2019 · 2 comments

Comments

@bazzargh
Copy link
Contributor

bazzargh commented Mar 4, 2019

If you change your password in okta, authentication fails here:

return fmt.Errorf("Failed to authenticate with okta: %#v", err)

...this is expected, but we're we're in a maze of authentication failures (session tokens etc). It'd be nice to indicate that this one is easy to fix: "If your password has changed, run aws-okta add again.", or perhaps "Invalid credentials, use aws-okta add to change them." - to cover more scenarios.

@nickatsegment
Copy link
Contributor

Yep, that'd be cool. I don't know if we can detect the difference between your password having changed and other non-network errors, like your user being deleted. But we could probably offer suggestions.

@stale
Copy link

stale bot commented May 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 5, 2019
@stale stale bot closed this as completed May 13, 2019
@nickatsegment nickatsegment added stale and removed stale labels May 17, 2019
bazzargh added a commit to bazzargh/aws-okta that referenced this issue Jun 12, 2019
I previously suggested this in segmentio#127, just providing a PR for it.
nickatsegment pushed a commit that referenced this issue Jun 12, 2019
I previously suggested this in #127, just providing a PR for it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants