Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

aws-okta complains about missing a aws_saml_url #113

Merged
merged 2 commits into from
Jan 24, 2019
Merged

aws-okta complains about missing a aws_saml_url #113

merged 2 commits into from
Jan 24, 2019

Conversation

Fauzyy
Copy link
Member

@Fauzyy Fauzyy commented Jan 24, 2019

This fixes the bug in master where aws-okta complains about a missing aws_saml_url

$ aws-okta login staging
aws_saml_url missing from ~/.aws/config

We've mixed up the error handling inside provider.go

  • Also added more steps to fix the bad credentials error message

@Fauzyy Fauzyy requested a review from nickatsegment January 24, 2019 00:55
@Fauzyy Fauzyy merged commit 959c738 into master Jan 24, 2019
@Fauzyy Fauzyy deleted the Fauzyy/fix-missing-saml-url-error branch January 24, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickatsegment nickatsegment nickatsegment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fauzyy @nickatsegment