This repository has been archived by the owner on May 18, 2021. It is now read-only.
Allows you to create docker image #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickatsegment
suggested changes
Feb 7, 2019
Dockerfile
Outdated
| WORKDIR /app/ | ||
| RUN apt-get update && apt-get -y install libusb-1.0-0 ca-certificates python-pip && pip install awscli | ||
| COPY --from=builder /go/src/github.com/segmentio/aws-okta/dist/aws-okta-*-linux-amd64 /app/aws-okta | ||
| COPY --from=builder /etc/passwd /etc/passwd |
There was a problem hiding this comment.
Is this to avoid the useradd? I'd prefer the useradd TBH
There was a problem hiding this comment.
Yes I usually use this way with alpine images, maybe I could move to alpine to make this image lighter or just avoid this and use useradd I will check it later.
nickatsegment
approved these changes
Mar 7, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added this in order to use aws-okta from a docker image, I think it is useful specially with windows users.