This repository has been archived by the owner on May 18, 2021. It is now read-only.
Add cmd flags #126
Closed
Add cmd flags #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I duplicated this PR (almost exactly too!) sorry about that: #137 |
|
oh cool! thanks @vivianho , no worries! great minds think alike. as long as it gets done. 🤷♂️ |
|
Ah, sorry @devinburnette I missed this one. #137 is merged. Thanks for your PR though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, I wanted to express how grateful we are for this tool. It's going to drastically change the way we do access management for the better across our engineering org. I was wondering if you think the following change is acceptable?
The first commit adds optional flags for the add command in lieu of asking for user input. We want to be able to roll this out for all engineers with an on-boarding process that's as seamless as possible. The flags will help us automate the things we already know about and only prompt for the things we don't.
The second commit is attempting to make the add command idempotent for the "okta-creds" key on a given backend. This makes it easy to run the add command every time and not get an error if the user already has their credentials populated in their keychain.
Happy to discuss our goals further and open to other ideas in accomplishing the same.