This repository has been archived by the owner on May 18, 2021. It is now read-only.
Allow assuming a source profile. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejcx
changed the title
If the source profile is itself, then don't do the second assume. Instead, just jump in to the okta enabled role.
ejcx
force-pushed
the
ej/support-source
branch
from
bd03a77 to
4a026ce
Compare
dfuentes
reviewed
Nov 15, 2017
lib/provider.go
Outdated
| // If sourceProfile returns the same source then we do not need to assume a | ||
| // second role. Not assuming a second role allows us to assume IDP enabled | ||
| // roles directly. | ||
| if source != sourceProfile(p.profile, p.profiles) { |
There was a problem hiding this comment.
I think this will always be false. Instead, you want if source != p.profile
p.profile is the chosen profile that is typed in. It should coorespond to an aws config profile. In the case that the profile's source profile is itself then we have found an idp enabled role and we should just log in to it instead of performing a second hop
|
@dfuentes nice catch. Source isn't actually what I wanted at all I don't think. When I switched the logic a different bug popped up |
|
Oh. I misread your comment a few hours ago which held this up. I have |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source profile is itself, then don't do the second assume.
Instead, just jump in to the okta enabled role.