This repository has been archived by the owner on May 18, 2021. It is now read-only.
feat: build with go 1.13 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickatsegment
force-pushed
the
go1.13
branch
6 times, most recently
from
093ec11 to
440a5a0
Compare
… of go Bump xerrors for better go1.13 support https://go-review.googlesource.com/c/xerrors/+/177379
nickatsegment
force-pushed
the
go1.13
branch
from
440a5a0 to
98bf75a
Compare
Rowno
reviewed
Sep 5, 2019
| @@ -1,8 +1,25 @@ | |||
| version: 2 | |||
| jobs: | |||
| test: | |||
|
|
|||
| test-build-golang-prev: | |||
| docker: | |||
| - image: circleci/golang:1.12 | |||
There was a problem hiding this comment.
Shouldn't you run the tests on golang:1.13 too? 🤔
There was a problem hiding this comment.
I guess it couldn't hurt, but I haven't seen it be a problem yet, so we'll cross that bridge when we get to it :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to bump xerrors to fix their go1.13 support.
Should cut a release after. The xerrors bump should fix Rowno's problem with our aws-okta homebrew recipe failing to build.
Fixes #209