Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

feat: Export expiration as AWS_OKTA_SESSION_EXPIRATION #230

Merged
merged 1 commit into from
Oct 17, 2019
Merged

feat: Export expiration as AWS_OKTA_SESSION_EXPIRATION #230

merged 1 commit into from
Oct 17, 2019

Conversation

douglaswth
Copy link
Contributor

This implements #190 as the AWS_OKTA_SESSION_EXPIRATION environment variable which is the expiration date as the number of seconds from the Unix epoch.

@nickatsegment nickatsegment changed the title Export expiration as AWS_OKTA_SESSION_EXPIRATION feat: Export expiration as AWS_OKTA_SESSION_EXPIRATION Oct 17, 2019
nickatsegment
nickatsegment approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@nickatsegment nickatsegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Sidenote: we should document these AWS_OKTA-specific env vars somewhere other than the code

@nickatsegment nickatsegment merged commit 47e49fc into segmentio:master Oct 17, 2019
This was referenced Oct 30, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickatsegment nickatsegment nickatsegment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglaswth @nickatsegment