Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Add deb/rpm package building and publishing #80

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Add deb/rpm package building and publishing #80

merged 3 commits into from
Sep 11, 2018

Conversation

nickatsegment
Copy link
Contributor

Basically copied segmentio/chamber#129

Fixes #79

@nickatsegment nickatsegment changed the title Add deb/rpm package building and publishing WIP: Add deb/rpm package building and publishing Sep 11, 2018
@nickatsegment
Copy link
Contributor Author

Ubuntu install test

$ docker run -it ubuntu sh -c 'apt-get update -q && apt-get install -yq curl && curl -s https://packagecloud.io/install/repositories/segment/aws-okta-prerelease/script.deb.sh | bash >/dev/null 2>&1 && apt-get install -yq aws-okta && aws-okta version'
Get:1 http://security.ubuntu.com/ubuntu bionic-security InRelease [83.2 kB]
...
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
  aws-okta
0 upgraded, 1 newly installed, 0 to remove and 6 not upgraded.
Need to get 4513 kB of archives.
After this operation, 14.0 MB of additional disk space will be used.
Get:1 https://packagecloud.io/segment/aws-okta-prerelease/ubuntu bionic/main amd64 aws-okta amd64 0.19.3-releasttest1 [4513 kB]
Fetched 4513 kB in 1s (4071 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
Selecting previously unselected package aws-okta.
(Reading database ... 4770 files and directories currently installed.)
Preparing to unpack .../aws-okta_0.19.3-releasttest1_amd64.deb ...
Unpacking aws-okta (0.19.3-releasttest1) ...
Setting up aws-okta (0.19.3-releasttest1) ...
aws-okta v0.19.3-releasttest1

@nickatsegment
Copy link
Contributor Author

Fedora install test

$ docker run -it fedora sh -c 'curl -s https://packagecloud.io/install/repositories/segment/aws-okta-prerelease/script.rpm.sh | bash && yum install -y aws-okta && aws-okta version'
Detected operating system as fedora/28.
Checking for curl...
Detected curl...
Downloading repository file: https://packagecloud.io/install/repositories/segment/aws-okta-prerelease/config_file.repo?os=fedora&dist=28&source=script
...
Dependencies resolved.
===================================================================================================================================================================================
 Package                            Arch                             Version                                           Repository                                             Size
===================================================================================================================================================================================
Installing:
 aws-okta                           x86_64                           0.19.3_releasttest1-1                             segment_aws-okta-prerelease                           4.2 M

Transaction Summary
===================================================================================================================================================================================
Install  1 Package

Total download size: 4.2 M
Installed size: 13 M
Downloading Packages:
aws-okta-0.19.3_releasttest1-1.x86_64.rpm                                                                                                          2.9 MB/s | 4.2 MB     00:01
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                                                              2.9 MB/s | 4.2 MB     00:01
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                           1/1
  Running scriptlet: aws-okta-0.19.3_releasttest1-1.x86_64                                                                                                                     1/1
  Installing       : aws-okta-0.19.3_releasttest1-1.x86_64                                                                                                                     1/1
  Running scriptlet: aws-okta-0.19.3_releasttest1-1.x86_64                                                                                                                     1/1
  Verifying        : aws-okta-0.19.3_releasttest1-1.x86_64                                                                                                                     1/1

Installed:
  aws-okta.x86_64 0.19.3_releasttest1-1

Complete!
aws-okta v0.19.3-releasttest1

@nickatsegment
Copy link
Contributor Author

@nickatsegment nickatsegment changed the title WIP: Add deb/rpm package building and publishing Add deb/rpm package building and publishing Sep 11, 2018
systemizer
systemizer reviewed Sep 11, 2018
View reviewed changes
.circleci/config.yml
- persist_to_workspace:
root: .
paths: ['dist/*']

release:
publish-linux:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we're not also publish darwin releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I should add a comment. Basically because the darwin build depends on Keychain libs that are not freely distributable, so we need a real macOS box to build this on, which is a whole other thing :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#81 for later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm not sure this is correct. Chamber uses Keychain as well, and yet it builds fine... Hmmm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, Chamber doesn't use keychain.

systemizer
systemizer approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@systemizer systemizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly to chamber pr, lgtm!

@nickatsegment nickatsegment merged commit b450f65 into master Sep 11, 2018
@nickatsegment nickatsegment deleted the add-deb-rpm-packages branch September 11, 2018 20:39
@nickatsegment
Copy link
Contributor Author

After merging this, I cut a new release v0.19.4 and it appears to have built and published everything correctly

https://circleci.com/workflow-run/124d882e-cb15-4425-b639-ce564f663694

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@systemizer systemizer systemizer approved these changes

@boggsboggs boggsboggs Awaiting requested review from boggsboggs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickatsegment @systemizer