This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Add support for ephemeral topics #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSQ now has support for ephemeral topics in addition to ephemeral channels. This change changes the regex to match that change. nsqio/nsq#305
|
lgtm, a test would help though |
|
👍 |
|
Would be nice with a feature where you could set e.g. |
|
@ralphtheninja what's the use case? |
|
This might be the wrong place for this discussion. The idea I had was to be able to use normal topics in your code and be able to flip an ephemeral switch to automatically make topics ephemeral, without needing to change every single one of them. Does that makes sense? |
yields
added a commit
that referenced
this pull request
Jun 22, 2015
Add support for ephemeral topics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSQ now has support for ephemeral topics in addition to ephemeral channels.
This change changes the regex to match that change.
nsqio/nsq#305