This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
Added test + fix for XML stylesheet declaration #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 12, 2015 19:19
- properly escaped the ? - made the . match lazy for safety - removed capturing group
mk-pmb
added a commit
to mk-pmb/xml-parser-fix-pmb
that referenced
this pull request
Aug 28, 2016
Added test + fix for XML stylesheet declaration [segmentio#15 imported]
|
Thanks for fixing! |
|
Have I missed something when mergeing? It still cannot parse jQuery.ajax.xml. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this parsing fails when it encounters an xml feed which has an
xml-stylesheettag like the following:The BBC news rss feed is an example.
I've written a test which fails without the changes, and implemented a fix that basically removes any content enclosed by
<? ?>that immediately follows the declaration.